Fix per stage ABFE BAR_Error by using correct loop var - #456
Conversation
|
CI failure is Think that's outside the scope of this PR. Happy to format if you'd like though. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 29 29
Lines 2446 2446
Branches 464 464
=======================================
Hits 2422 2422
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test failure also seems unrelated: |
|
I raised #458 for the failures that seem unrelated to your changes. For the ruff formatting a separate PR with only formatting changes would be preferred. I'll merge the PR given that @xiki-tempula approved it. |
orbeckst
left a comment
There was a problem hiding this comment.
Thanks for the fix. Please
- add yourself to AUTHORS under a new 2026 heading
- add your GitHub handle to the 2.6.0 author line in CHANGELOG
Happy to merge then.
|
Thanks @xiki-tempula and @orbeckst ! Have made the requested changes. Should I add myself to |
|
Yes, please, add yourself after Lines 109 to 112 in 220141f Good point! |
orbeckst
left a comment
There was a problem hiding this comment.
Add yourself to CITATION.
I'll fix CHANGELOG.
I'll approve, assuming that the CITATION.cff fix will happen before anyone merges.
|
Ah nice, thanks for the fix. Have updated citation.cff |
|
Thank you @jberg5 , much appreciated!! |
Fixes #455.
Also updated the example docstring with corrected per-stage error values.